Page 5 of 7 |
|
|
Back to top |
|
 |
TSR69
Banned
Posts: 14962
Location: Republic of the Seven United Provinces
|
|
Back to top |
|
 |
ixigia
[Moderator] Consigliere
Posts: 65098
Location: Italy
|
Posted: Sun, 18th Nov 2012 18:17 Post subject: |
|
 |
besthijacker wrote: | ixigia wrote: | edit: btw everything seems to fixed now (and improved)..we're almost nextgen, thanks Mrt  |
Nextgen will be when forum upgrades to phpbb 3!  |
Haha boo! that stuff if for kids and social networks, we must remain old-school, blue and absolutely not trendy-ish..otherwise we'll attract too many derps 
|
|
Back to top |
|
 |
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 18:26 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 18:37 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
TSR69
Banned
Posts: 14962
Location: Republic of the Seven United Provinces
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:14 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 19:15 Post subject: |
|
 |
Okay, I've noticed two bugs ---
Firstly; Chrome seems to pitch a fit when dealing with resizing large images, pretty sizeable CPU spike and a temporary burst of memory usage.
Secondly; the YT embedding is great - except on pages where there's a LOT of YT links, such as this one; http://www.nfohump.com/forum/viewtopic.php?t=61850 -- the videos either don't load (no thumbnails or player controls), or they screw up the page with black boxes ---- not to mention the CPU goes nuts and memory usage shoots through the roof, it went from 80MB tab to 1.2GB in a matter of seconds and it showed no sign of slowing down or stopping, I had to force the tab closed.
~edit~
Actually, it stopped at 1.39GB and finally loaded all the videos. Wow. I guess having so many embedded vids at once is pretty rough, eh?

Last edited by sabin1981 on Sun, 18th Nov 2012 19:31; edited 1 time in total
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:20 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
|
Back to top |
|
 |
TSR69
Banned
Posts: 14962
Location: Republic of the Seven United Provinces
|
Posted: Sun, 18th Nov 2012 19:27 Post subject: |
|
 |
It took some time here but loaded fine, 670 MB for the tab. ATM I don't use garus' add-on.
Edit: I tried using this:
Code: | [url=http://www.youtube.com/watch?v=uw9Q6GTEPYw]Politically Incorrect, Women/ Feminism-Part 1[/url] |
Without the code tags, it embeds as well.
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:29 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 19:37 Post subject: |
|
 |
you can make it universal by changing width to 100% instead of a fixed pixel value
and clicking would toggle between 100% and nothing
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:40 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 19:44 Post subject: |
|
 |
would need a check if image is bigger than screen though
conditional css perhaps?
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:45 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 19:56 Post subject: |
|
 |
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 19:59 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 20:13 Post subject: |
|
 |
ah
silly me
just use max-width property instead of width
no conditinals required
so
click to toggle between
style="max-width:100%;"
and
style=""
|
|
Back to top |
|
 |
LeoNatan
☢ NFOHump Despot ☢
Posts: 73255
Location: Ramat HaSharon, Israel 🇮🇱
|
Posted: Sun, 18th Nov 2012 20:21 Post subject: |
|
 |
LeoNatan wrote: | Hey mrt, thanks for the hard work!
One suggestion that I think will help a lot of the mobile users is putting the "mark all forums as read" a page deeper. I mean, clicking on the link will point to a dummy page that asks "are you sure?" and if yes, it will point to the normal link. It's a simple tweak (no need for some PHP logic), and will save many frustrations we have.  |
QFNP 
|
|
Back to top |
|
 |
|
|
Back to top |
|
 |
Raccoon
Posts: 3160
Location: Poland
|
Posted: Sun, 18th Nov 2012 21:21 Post subject: |
|
 |
|
|
Back to top |
|
 |
LeoNatan
☢ NFOHump Despot ☢
Posts: 73255
Location: Ramat HaSharon, Israel 🇮🇱
|
Posted: Sun, 18th Nov 2012 22:38 Post subject: |
|
 |
Hi mrt,
Some feedback:
Shortened youtu.be links are not recognized as media files, thus not embedded.
And here is a better resizing algorithm, I think:
Code: | function hugeimage_fit()
{
var hugies = $("div#userPost img");
var pos = $("#userPost").offset();
var max_width = $(window).width();
if(window.devicePixelRatio)
{
max_width /= devicePixelRatio;
}
max_width - pos.left - 50;
hugies.each(function(i, el) {
jel = $(el);
var img_width = jel.width();
if(img_width > max_width)
{
jel.css('width', max_width);
jel.css('cursor', 'pointer');
jel.click(function() {
var t = $(el);
var cap = '';
if(t.width() <= max_width)
{
t.css('width', 'auto');
}
else
{
t.css('width', max_width);
}
});
}
});
} |
This way, the device pixel ratio is calculated, and on an iPad 3 the actual resolution is not determined as 2048 but 1024.
|
|
Back to top |
|
 |
garus
VIP Member
Posts: 34197
|
Posted: Sun, 18th Nov 2012 22:46 Post subject: |
|
 |
snip
Last edited by garus on Tue, 27th Aug 2024 21:55; edited 1 time in total
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 22:51 Post subject: |
|
 |
but it doesn't need to be calculated at all
setting max-width to 100% will leave the image alone if it is small and limit its size to fit the thread if it's too big
|
|
Back to top |
|
 |
LeoNatan
☢ NFOHump Despot ☢
Posts: 73255
Location: Ramat HaSharon, Israel 🇮🇱
|
Posted: Sun, 18th Nov 2012 23:11 Post subject: |
|
 |
@shole The problem is, this script only runs at the end of rendering, so while the image loads, the document width has grown already. Setting 100% will leave it as is, as the document grew in size.
@garus And what is a proper resolution? Hardware resolution is indeed 2048x1536, but this is not the resolution that should be used. When working with a viewport, it is independent on the hardware resolution. It creates a virtual resolution, and the scale indicates the ratio between the virtual resolution and the actual hardware resolution.
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 23:36 Post subject: |
|
 |
100% is not to document size
it is relative to the parent
try it
Spoiler: | |
auto - stretched to huge scale
Spoiler: | |
100% - fit to it's parent
if relative css scales could influence itself from absolute values it previously had it would get into infinitely recursive feedback loop and stretch the web page into infinity
|
|
Back to top |
|
 |
|
Posted: Sun, 18th Nov 2012 23:49 Post subject: |
|
 |
What's with the Forum/NFO's/Reviews buttons? They are kinda... Out of bounds...
"Quantum mechanics is actually, contrary to it's reputation, unbeliveably simple, once you take the physics out."
Scott Aaronson chiv wrote: | thats true you know. newton didnt discover gravity. the apple told him about it, and then he killed it. the core was never found. | 
|
|
Back to top |
|
 |
Page 5 of 7 |
All times are GMT + 1 Hour |